Found 61 issues

First time here? 👋

Welcome to Find a PR.

Find a PR is an open-source site that is built to help developers find projects so that they can submit their very first pull request.

If you're a contributor looking to find a project to contribute to, feel free to browse through the list below.

If you're a maintainer looking to list your project on Find a PR, you can read how to do this in the documentation.

bug enhancement good first issue

What happened?

I just installed package and complement for AI powered solution. When I create an issue to test it I get :

Capture d'écran 2024-07-21 125216

I had to change the links function like this to make it work for me:

public function links(): array
{
    $rawText = Str::finish($this->rawText, 'ENDLINKS');

    $textLinks = $this->between('LINKS', 'ENDLINKS', $rawText);

    $textLinks = explode(PHP_EOL, $textLinks);

    $links = [];

    foreach ($textLinks as $textLink) {
        $textLink = str_replace('\\', '\\\\', $textLink);
        $textLink = str_replace('\\\\\\', '\\\\', $textLink);

        $decodedLink = json_decode($textLink, true);

        if ($decodedLink !== null) {
            $links[$decodedLink['title']] = $decodedLink['url'];
        }
    }

    return $links;
}

How to reproduce the bug

When I install the package in my project and use it with AI powered

Package Version

1.0

PHP Version

8.2.14

Laravel Version

11.14

Which operating systems does with happen with?

Windows

Notes

No response

View more
2 comments
bestmomo

bestmomo

21st Jul 2024 @ 10:57

help wanted findapr

I tried the example config from the docs to a Laravel/Inertia/Vue app, and it don't work.

If use the code (HandleInertiaRequests.php): 'messages' => flash()->render([], 'array'),

Error: Flasher\Prime\Flasher::render(): Argument #1 ($presenter) must be of type string, array given, called in D:\Laragon6\www\mobi-care\app\Http\Middleware\HandleInertiaRequests.php on line 36

And changing it to: 'messages' => flash()->render('array'), it loads the page, but, I only see the notifications if i press F5, with its not the desired state.

View more
brunonetadmin

brunonetadmin

18th Mar 2025 @ 17:16

help wanted

Add in PHP 7.3 as Normalizer::normalize() argument for NFKC_Casefold normalization.

View more
1 comment
nicolas-grekas

nicolas-grekas

7th Feb 2019 @ 10:11

help wanted

Laravel Version

12.34.0

PHP Version

8.3.25

Database Driver & Version

MySQL 8.0 on Windows 11 (WSL + Laravel Sail)

Description

When running tests inside Laravel Sail with Xdebug enabled, marking a test as incomplete with $this->markTestIncomplete() triggers a ParseError:

ParseError: Unclosed '('
in vendor/laravel/framework/src/Illuminate/View/Compilers/BladeCompiler.php:623

This error does not occur when Xdebug is disabled. It seems related to the intefraction between BladeCompiler and Xdebug, possibly involving view cache or teardown behavior during PHPUnit test execution.

Steps To Reproduce

  • Create any PHPUnit test in a Laravel Project;
  • Inside the test, add the markTestIncomplete method:
    public function test_category_can_be_restored(): void
    {
        $this->markTestIncomplete();
    }
  • Run tests with Xdebug enabled:
  • sail test (with alias) or ./vendor/bin/sail test;
  • Observe the error:
    protected function hasEvenNumberOfParentheses(string $expression)
    {
        $tokens = token_get_all('<?php '.$expression);
>> Exception has occurred.
>> ParseError: Unclosed '('
View more
1 comment 👍 1
vwinck-dev

vwinck-dev

21st Oct 2025 @ 13:47

help wanted question

AST, or "abstract syntax tree", creates the expectation of a nested tree structure. In the case of a query string, the AST will only ever be one level deep; as multi nodes are combined into one.

If anyone wants to suggest a better, more clear name: you're welcome.

View more
3 comments
brendt

brendt

20th Dec 2018 @ 13:41

good first issue
View more
2 comments
Kocal

Kocal

28th Jan 2025 @ 21:55

enhancement help wanted hacktoberfest

Describe the bug I have a table which has an order column. When I reorder the elements I update each model with the new order. Because the table has some large JSON columns I select only id and order columns for efficiency. I set the new order and save the model.

foreach (Faq::query()->get(['id', 'order']) as $faq) {
    $faq->order = $newOrder[$faq->id];
    $faq->save();
}

The diffs created in the activity_log table look like this:

{
   "old": {
      "order": 1,
      "answer": null,
      "question": null
   },
   "attributes": {
      "order": 2,
      "answer": "long JSON content",
      "question": "long JSON content"
   }
}

From what I see laravel-activitylog fetches the model with all columns from the database before creating a log entry which kind of defeats the purpose of my "select list optimization" and produces an incorrect diff.

Generally I want these large JSON columns to be logged in case a user changes them but in this case I only change the order column so I would like to see only the order column in the diff.

I have tried running these updates straight off the Eloquent builder:

Faq::query()->where('id', $id)->update(['order' => $newOrder[$id]]);

but in this case nothing is logged.

I have the following activitylog configuration for my models:

public function getActivitylogOptions(): LogOptions
{
    return LogOptions::defaults()
                     ->logAll()
                     ->logOnlyDirty()
                     ->logExcept([
                         'id',
                         'created_at',
                         'updated_at',
                     ]);
}

To Reproduce Select a subset of columns from the database, change these columns, save the model and see that other (not initially selected) columns are present in the diff.

Expected behavior Only columns that've actually been changed should be present in the diff.

Versions

  • PHP: 8.1
  • Database: MySQL 8
  • Laravel: 9.31.0
  • Package: 4.6.0
View more
6 comments 👍 1
KKSzymanowski

KKSzymanowski

28th Sep 2022 @ 21:53

help wanted

Hi 👋🏼!

I am coming here to gather some feedback on my idea before starting working on it.

Background

I wanted to create a POC of https://github.com/symfony/skeleton made for Sylius. I created a simple recipe for sylius/core-bundle, then an example skeleton repo and I have found out my recipes does not work as another recipe already write files with the same name. Then, I noticed symfony/framework-bundle is always put as the first recipe to be executed, and this is a thing I wish to be able to configure.

Goal

Somehow allow myself to make (in this POC case) sylius/core-bundle as a first recipe to be executed. Of course, I can fork symfony/flex, but it would be perfect to avoid this way.

Idea

The idea is simple, we allow configuring such list for example in this way:

{
    ...
    "extra": {
        "flex": {
            "prioritized-recipes": [
                "sylius/core-bundle",
                "another/sylius-package",
                ...
            ]
        }
    }
    ...
}

In Flex we could implement this +/- this way:

        // symfony/framework-bundle recipe should always be applied first after the metapackages
        // however, we allow to override it with a list of prioritized recipes
        $recipes = $this->getPrioritizedRecipes();
        $recipes = array_merge($recipes, [
            'symfony/framework-bundle' => null,
        ]);
        $packRecipes = [];
        $metaRecipes = [];

instead current

        // symfony/framework-bundle recipe should always be applied first after the metapackages
        $recipes = [
            'symfony/framework-bundle' => null,
        ];
        $packRecipes = [];
        $metaRecipes = [];

Why?

  • In some projects, we may want to load our recipes before the Symfony's ones
  • In frameworks based on Symfony (like Sylius) we need to set up the whole project in our own way, so framework-bundle as a first recipe to be executed makes it unable for us

Other options

I have not checked it yet, but I believe we can achieve the similar feature using Composer's Event Dispatcher. But first, I would like to hear if such a feature is welcomed. Or maybe you have a better idea how to solve this. I am open to provide such feature right after we agree on some solution.

View more
6 comments ❤️ 1
jakubtobiasz

jakubtobiasz

7th Nov 2022 @ 19:24

help wanted findapr

Hello, When using php-flasher-toastr with Laravel 11, I encounter a TypeError: array_replace_recursive(): Argument #2 must be of type array, int given error in Illuminate\Translation\FileLoader at line 130. My environment:

  • PHP: 8.3.7
  • Laravel: 11.4.2
  • php-flasher/flasher-toastr-laravel: 2.1
  • php-flasher/flasher-laravel: 2.1 The error disappears when I uninstall php-flasher/flasher-toastr-laravel and php-flasher/flasher-laravel. Alternatively, ensuring that the value passed to with() is always a string (e.g., with('success', 'Message')) prevents the error.
View more
2 comments
Gnoth2n5

Gnoth2n5

27th Mar 2025 @ 17:30

help wanted

Laravel Version

12.28.1

PHP Version

8.3.26

Database Driver & Version

No response

Description

When using a closure in a job chain after batch jobs (as documented in the "Chains and Batches" section of the Queue documentation), the chain fails with a Call to undefined method Closure::getClosure() error.

This occurs specifically when:

  1. A job chain contains one or more batches
  2. A closure is placed in the chain after the batch(es)
  3. The batch completes successfully
  4. The ChainedBatch callback attempts to dispatch the next item (the closure)

Steps To Reproduce

Create three simple job classes with the Batchable trait:

// app/Jobs/FlushPodcastCache.php
<?php

namespace App\Jobs;

use Illuminate\Bus\Batchable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Queue\Queueable;

class FlushPodcastCache implements ShouldQueue
{
    use Queueable, Batchable;

    public function handle(): void
    {
        // Implementation
    }
}

// app/Jobs/ReleasePodcast.php
<?php

namespace App\Jobs;

use Illuminate\Bus\Batchable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Queue\Queueable;

class ReleasePodcast implements ShouldQueue
{
    use Queueable, Batchable;

    public function __construct(public int $id) {}

    public function handle(): void
    {
        // Implementation
    }
}

// app/Jobs/SendPodcastReleaseNotification.php
<?php

namespace App\Jobs;

use Illuminate\Bus\Batchable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Queue\Queueable;

class SendPodcastReleaseNotification implements ShouldQueue
{
    use Queueable, Batchable;

    public function __construct(public int $id) {}

    public function handle(): void
    {
        // Implementation
    }
}

Then dispatch a chain with batches followed by a closure:

use App\Jobs\FlushPodcastCache;
use App\Jobs\ReleasePodcast;
use App\Jobs\SendPodcastReleaseNotification;
use Illuminate\Support\Facades\Bus;
use Illuminate\Support\Facades\Log;

Bus::chain([
    new FlushPodcastCache,
    Bus::batch([
        new ReleasePodcast(1),
        new ReleasePodcast(2),
    ]),
    Bus::batch([
        new SendPodcastReleaseNotification(1),
        new SendPodcastReleaseNotification(2),
    ]),
    function() {
        Log::debug('Closure Run');
    }
])->dispatch();

Expected Behavior

The closure should execute after all batches complete successfully, as documented in the Laravel Queue documentation under "Job Chaining" which explicitly shows that closures can be mixed with job classes in chains.

Actual Behavior

The chain processes successfully through all jobs and batches, but when ChainedBatch attempts to dispatch the closure, it throws:

Call to undefined method Closure::getClosure() at /app/vendor/laravel/framework/src/Illuminate/Queue/CallQueuedClosure.php:113

Stack Trace

[2025-10-30 17:31:09] local.ERROR: Call to undefined method Closure::getClosure() {"exception":"[object] (Error(code: 0): Call to undefined method Closure::getClosure() at /app/vendor/laravel/framework/src/Illuminate/Queue/CallQueuedClosure.php:113)
[stacktrace]
#0 /app/vendor/laravel/framework/src/Illuminate/Queue/Queue.php(208): Illuminate\\Queue\\CallQueuedClosure->displayName()
#1 /app/vendor/laravel/framework/src/Illuminate/Queue/Queue.php(164): Illuminate\\Queue\\Queue->getDisplayName()
#2 /app/vendor/laravel/framework/src/Illuminate/Queue/Queue.php(149): Illuminate\\Queue\\Queue->createObjectPayload()
#3 /app/vendor/laravel/framework/src/Illuminate/Queue/RedisQueue.php(283): Illuminate\\Queue\\Queue->createPayloadArray()
#4 /app/vendor/laravel/horizon/src/RedisQueue.php(89): Illuminate\\Queue\\RedisQueue->createPayloadArray()
#5 /app/vendor/laravel/framework/src/Illuminate/Queue/Queue.php(121): Laravel\\Horizon\\RedisQueue->createPayloadArray()
#6 /app/vendor/laravel/horizon/src/RedisQueue.php(47): Illuminate\\Queue\\Queue->createPayload()
#7 /app/vendor/laravel/framework/src/Illuminate/Bus/Dispatcher.php(246): Laravel\\Horizon\\RedisQueue->push()
#8 /app/vendor/laravel/framework/src/Illuminate/Bus/Dispatcher.php(230): Illuminate\\Bus\\Dispatcher->pushCommandToQueue()
#9 /app/vendor/laravel/framework/src/Illuminate/Bus/Dispatcher.php(80): Illuminate\\Bus\\Dispatcher->dispatchToQueue()
#10 laravel-serializable-closure://function (\\Illuminate\\Bus\\Batch $batch) use ($next) {
                if (! $batch->cancelled()) {
                    \\Illuminate\\Container\\Container::getInstance()->make(\\Illuminate\\Contracts\\Bus\\Dispatcher::class)->dispatch($next);
                }
            }(4): Illuminate\\Bus\\Dispatcher->dispatch()
#11 [internal function]: Illuminate\\Bus\\ChainedBatch::{closure}()
#12 /app/vendor/laravel/serializable-closure/src/Serializers/Signed.php(43): call_user_func_array()
#13 [internal function]: Laravel\\SerializableClosure\\Serializers\\Signed->__invoke()
#14 /app/vendor/laravel/serializable-closure/src/SerializableClosure.php(39): call_user_func_array()
#15 /app/vendor/laravel/framework/src/Illuminate/Bus/Batch.php(458): Laravel\\SerializableClosure\\SerializableClosure->__invoke()
#16 /app/vendor/laravel/framework/src/Illuminate/Bus/Batch.php(280): Illuminate\\Bus\\Batch->invokeHandlerCallback()
#17 /app/vendor/laravel/framework/src/Illuminate/Bus/Batch.php(257): Illuminate\\Bus\\Batch->invokeCallbacks()
#18 /app/vendor/laravel/framework/src/Illuminate/Queue/CallQueuedHandler.php(203): Illuminate\\Bus\\Batch->recordSuccessfulJob()
#19 /app/vendor/laravel/framework/src/Illuminate/Queue/CallQueuedHandler.php(76): Illuminate\\Queue\\CallQueuedHandler->ensureSuccessfulBatchJobIsRecorded()
#20 /app/vendor/laravel/framework/src/Illuminate/Queue/Jobs/Job.php(102): Illuminate\\Queue\\CallQueuedHandler->call()
#21 /app/vendor/laravel/framework/src/Illuminate/Queue/Worker.php(451): Illuminate\\Queue\\Jobs\\Job->fire()
#22 /app/vendor/laravel/framework/src/Illuminate/Queue/Worker.php(401): Illuminate\\Queue\\Worker->process()
#23 /app/vendor/laravel/framework/src/Illuminate/Queue/Worker.php(187): Illuminate\\Queue\\Worker->runJob()
#24 /app/vendor/laravel/framework/src/Illuminate/Queue/Console/WorkCommand.php(148): Illuminate\\Queue\\Worker->daemon()
#25 /app/vendor/laravel/framework/src/Illuminate/Queue/Console/WorkCommand.php(131): Illuminate\\Queue\\Console\\WorkCommand->runWorker()
#26 /app/vendor/laravel/horizon/src/Console/WorkCommand.php(52): Illuminate\\Queue\\Console\\WorkCommand->handle()
#27 /app/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(36): Laravel\\Horizon\\Console\\WorkCommand->handle()
#28 /app/vendor/laravel/framework/src/Illuminate/Container/Util.php(43): Illuminate\\Container\\BoundMethod::Illuminate\\Container\\{closure}()
#29 /app/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(96): Illuminate\\Container\\Util::unwrapIfClosure()
#30 /app/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(35): Illuminate\\Container\\BoundMethod::callBoundMethod()
#31 /app/vendor/laravel/framework/src/Illuminate/Container/Container.php(836): Illuminate\\Container\\BoundMethod::call()
#32 /app/vendor/laravel/framework/src/Illuminate/Console/Command.php(211): Illuminate\\Container\\Container->call()
#33 /app/vendor/symfony/console/Command/Command.php(318): Illuminate\\Console\\Command->execute()
#34 /app/vendor/laravel/framework/src/Illuminate/Console/Command.php(180): Symfony\\Component\\Console\\Command\\Command->run()
#35 /app/vendor/symfony/console/Application.php(1073): Illuminate\\Console\\Command->run()
#36 /app/vendor/symfony/console/Application.php(356): Symfony\\Component\\Console\\Application->doRunCommand()
#37 /app/vendor/symfony/console/Application.php(195): Symfony\\Component\\Console\\Application->doRun()
#38 /app/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(197): Symfony\\Component\\Console\\Application->run()
#39 /app/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(1235): Illuminate\\Foundation\\Console\\Kernel->handle()
#40 /app/artisan(16): Illuminate\\Foundation\\Application->handleCommand()
#41 {main}
"} 

Additional Context

  • Closures work fine in chains when NOT following batches
  • Using a job class instead of a closure works as expected
  • The issue appears to be in how ChainedBatch serializes/deserializes the closure for dispatch
  • This follows the exact pattern documented at https://laravel.com/docs/12.x/queues#chains-and-batches
View more
4 comments
panVag

panVag

30th Oct 2025 @ 17:45

help wanted

What about allowing displaying post-install messages again, eg when running this?

composer recipes the/package

View more
nicolas-grekas

nicolas-grekas

1st Jun 2022 @ 09:13

help wanted

Laravel Version

12.36.1

PHP Version

8.3.27

Database Driver & Version

No response

Description

The pre-package-uninstall Composer event triggers Illuminate\Foundation\ComposerScripts::prePackageUninstall which boots the application. The boot fails if a service provider (in app/Providers/) is extending a service provider of a package which is not installed at the moment.

The error message:

Installing dependencies from lock file (including require-dev) Verifying lock file contents can be installed on current platform. Package operations: 33 installs, 0 updates, 2 removals > Illuminate\Foundation\ComposerScripts::prePackageUninstall

In AdminPanelProvider.php line 22:

[Error]
Class "Filament\PanelProvider" not found

Exception trace: [...]

Steps To Reproduce

  1. Create branch-a from main and switch to it
  2. Add a Composer package that includes a service provider you should extend within your app:
    composer require filament/filament:"^4.0"
    php artisan filament:install --panels
    
    (This creates app/Providers/Filament/AdminPanelProvider.php which extends \Filament\PanelProvider and adds it to bootstrap/providers.php.)
  3. Create branch-b from main and switch to it
  4. Install any Composer package (e.g. composer r --dev barryvdh/laravel-debugbar)
  5. Switch to branch-a and run composer install
View more
4 comments 👍 3
halloei

halloei

31st Oct 2025 @ 12:09

bug help wanted

What happened?

After installation, I noticed that in the browser console it outputs an error of wireEl is undefined.

How to reproduce the bug

Just install this package in a livewire project, preferable with Filament's admin package. And see the browser console.

composer create-project laravel/laravel test;
composer require filamentphp/filament;
composer require spatie/laravel-blade-comments;

Then go through the browser console and see the error

Package Version

1.0.1

PHP Version

8.2.0

Laravel Version

10.13.0

Which operating systems does with happen with?

macOS

Notes

Filament ......................................................
Packages ...... filament, forms, notifications, support, tables
Version .............................................. v2.17.44
Views ..................................... PUBLISHED: filament

View more
5 comments 👍 2
sawirricardo

sawirricardo

2nd Jun 2023 @ 07:15

help wanted

If a pack lists things in its "replace" section, unpacking this pack should copy these rules into the "replace" section of the root composer.json.

I think that implementing this requires patching the Unpacker class only.

Anyone up to give it a try?

View more
2 comments
nicolas-grekas

nicolas-grekas

8th Jul 2020 @ 18:35

help wanted

Describe the bug

When you attempt to dump a binary string or anything containing one (like an array or an object), Ray does not dump anything. It just fails silently.

Versions

Ray version (you can see this in "About Ray"): 2.8.1

You can use composer show to get the version numbers of:

  • spatie/ray package version: 1.41.2
  • spatie/laravel-ray package version (if applicable): 1.37.1

PHP version: 8.2.17 Laravel version (if applicable): 11.18.1

To Reproduce

Add this in your code:

ray(hex2bin('ae0f3d'));

Expected behavior

Ray should display this (like the console when dump is used):

b"®\x0F="

Desktop (please complete the following information):

  • OS: MacOs
  • Version: 14.6.1
View more
6 comments 👍 1
sebj54

sebj54

27th Aug 2024 @ 14:57

enhancement good first issue

using prompt engineering techniques provide enhancement to the Claude service class in the Claude prompt class, creating functions commonly used in Laravel applications. For example, brand builder, seo product optimizer, video and or image captioner, automated chatbots #goodfirstissue

View more
kwakuOfosuAgyeman

kwakuOfosuAgyeman

5th Jan 2025 @ 05:38

help wanted hacktoberfest good first issue documentation

We are logging activity of several models, some using SoftDeletes trait and others not.

When we set config option 'subject_returns_soft_deleted_models' => true then calling subject() on any model not using SoftDeletes trait throws an exception: Call to undefined method Illuminate\Database\Eloquent\Builder::withTrashed().

Can the subject() method below be made to check first whether the Model uses the SoftDeletes trait? Or perhaps check whether withTrashed() is a defined method on the Model? I tried a few things but couldn't figure out how to get the class of the Model..

https://github.com/spatie/laravel-activitylog/blob/68eb6e65382f94fe86ce5ff6572159f80d024ba9/src/Models/Activity.php#L28-L35

View more
26 comments
bluec

bluec

7th Nov 2018 @ 13:44

help wanted findapr

Immediately after installing php-flasher/flasher-laravel, the application breaks with the following error:

foreach() argument must be of type array|object, bool given Simply installing the package causes this fatal error.

Steps to Reproduce:

Create a fresh Laravel app.

Run:

composer require php-flasher/flasher-laravel

Load any page in the app — no usage of flasher() or flasher_render() yet.

Laravel crashes with a foreach() error.

View more
8 comments
dlopez525

dlopez525

11th Apr 2025 @ 18:20

help wanted

Octane Version

v2.3.10

Laravel Version

v11.6.0

PHP Version

v8.3.6

What server type are you using?

FrankenPHP

Server Version

v1.1.4 PHP 8.3.6 Caddy v2.7.6

Database Driver & Version

Postgress

Description

Last week we updated our app previously using php-fpm running on Forge to use Laravel Octane with FrankenPHP. Our site is mostly an API that handles analytics events (Like google analytics). It uses the default Laravel api throttling.

In staging our app worked fine (30 req/sec same IP), but when deploying to production (1400 req/sec, different IPs) it started to fail, giving a lot of 429 Too Many Requests.

image

I quickly rolled back to php-fpm and after a few hours tried again with the same problem. Rolled back and the next day I switched to Swoole and it worked perfectly without changing a single line of code nor having to redeploy anything. So I can confidently say that is NOT a bug in my code, but rather a bug with FrankenPHP or the Octane integration with FrankenPHP.

My theory is that the RateLimiter is not reseting between requests so it's shared between different users. So multiple different users trigger the rate limiter:

This is my Rate limiter configuration:

// AppServiceProvider

RateLimiter::for('api', function (Request $request) {
    return Limit::perMinute(60)->by($request->user()?->id ?: $request->ip());
});

our production CACHE_STORE is redis. Throttling worked perfectly fine without octane and with octane but using Swoole. It failed with hundred of 429 Too Many Requests after installing FrankenPHP.

This is our bootstrap/app.php:

<?php

use Illuminate\Foundation\Application;
use Illuminate\Foundation\Configuration\Exceptions;
use Illuminate\Foundation\Configuration\Middleware;
use Illuminate\Support\Facades\App;

return Application::configure(basePath: dirname(__DIR__))
    ->withRouting(
        commands: __DIR__.'/../routes/console.php',
        health: '/up',
        then: function () {
            Route::middleware('api')
                ->prefix('api')
                ->as('api.')
                ->domain(config('app.domain'))
                ->group(base_path('routes/api.php'));

            Route::middleware('web')
                ->domain(config('app.domain'))
                ->group(base_path('routes/web.php'));

            Route::middleware('web')
                ->domain(config('playsaurus.ads.domain'))
                ->group(base_path('routes/ads.php'));
        }
    )
    ->withMiddleware(function (Middleware $middleware) {
        $middleware->throttleApi();

        $middleware->redirectTo(
            guests: '/login',
            users: '/',
        );

        $middleware->web(append: [
            \App\Http\Middleware\HandleInertiaRequests::class,
            \Illuminate\Http\Middleware\AddLinkHeadersForPreloadedAssets::class,
        ]);

        $middleware->api(append: [
            \App\Http\Middleware\ConfigureLocale::class,
        ]);

        $middleware->alias([
            'localize' => \App\Http\Middleware\ConfigureLocale::class,
            'embed' => \App\Http\Middleware\AllowsEmbeding::class,
        ]);
    })
    ->withExceptions(function (Exceptions $exceptions) {
        $exceptions->dontReport([
            \App\Services\Announcements\InvalidVariantKey::class,
            \App\Exceptions\CouponRedeemException::class,
        ]);
    })->create();

Steps To Reproduce

It's difficult to reproduce. Because I can't test it in production because that would mean a lot of downtime for our users.

My theory is that it would be possible to reproduce from multiple different IPs. But since I don't have the means to test it, I don't know.

View more
12 comments 👍 1
jhm-ciberman

jhm-ciberman

14th May 2024 @ 00:15

help wanted

When calling mb_convert_encoding() with $fromEncoding === 'HTML-ENTITIES', the polyfill does not return functionally equivalent strings to the native function. This is because mb_convert_encoding() uses html_entity_decode() when $fromEncoding === 'HTML-ENTITIES' and that function does not return characters for many numeric entities 0-31 and 127-159. For example:

<?php

require "vendor/symfony/polyfill-mbstring/Mbstring.php";

use Symfony\Polyfill\Mbstring as p;

for($i = 0; $i < 1024; $i++) {
	$string = "&#" . $i . ";";
	$mbstring = mb_convert_encoding($string, 'UTF-8', 'HTML-ENTITIES');
	$polyfill = p\Mbstring::mb_convert_encoding($string, 'UTF-8', 'HTML-ENTITIES');
	if($mbstring != $polyfill) {
		echo "Mismatch: $string - mbstring: $mbstring; polyfill: $polyfill\n";
	}
}

outputs:

Mismatch: &#0; - mbstring: ; polyfill: &#0;
Mismatch: &#1; - mbstring: ; polyfill: &#1;
Mismatch: &#2; - mbstring: ; polyfill: &#2;
Mismatch: &#3; - mbstring: ; polyfill: &#3;
Mismatch: &#4; - mbstring: ; polyfill: &#4;
Mismatch: &#5; - mbstring: ; polyfill: &#5;
Mismatch: &#6; - mbstring: ; polyfill: &#6;
Mismatch: &#7; - mbstring: ; polyfill: &#7;
Mismatch: &#8; - mbstring:; polyfill: &#8;
Mismatch: &#11; - mbstring:
                            ; polyfill: &#11;
Mismatch: &#12; - mbstring:
                            ; polyfill: &#12;
Mismatch: &#14; - mbstring: ; polyfill: &#14;
Mismatch: &#15; - mbstring: ; polyfill: &#15;
Mismatch: &#16; - mbstring: ; polyfill: &#16;
Mismatch: &#17; - mbstring: ; polyfill: &#17;
Mismatch: &#18; - mbstring: ; polyfill: &#18;
Mismatch: &#19; - mbstring: ; polyfill: &#19;
Mismatch: &#20; - mbstring: ; polyfill: &#20;
Mismatch: &#21; - mbstring: ; polyfill: &#21;
Mismatch: &#22; - mbstring: ; polyfill: &#22;
Mismatch: &#23; - mbstring: ; polyfill: &#23;
Mismatch: &#24; - mbstring: ; polyfill: &#24;
Mismatch: &#25; - mbstring: ; polyfill: &#25;
Mismatch: &#26; - mbstring: ; polyfill: &#26;
Mismatch: &#27; - mbstring:  polyfill: &#27;
Mismatch: &#28; - mbstring: ; polyfill: &#28;
Mismatch: &#29; - mbstring: ; polyfill: &#29;
Mismatch: &#30; - mbstring: ; polyfill: &#30;
Mismatch: &#31; - mbstring: ; polyfill: &#31;
Mismatch: &#39; - mbstring: '; polyfill: &#39;
Mismatch: &#127; - mbstring: ; polyfill: &#127;
Mismatch: &#128; - mbstring: €; polyfill: &#128;
Mismatch: &#129; - mbstring: ; polyfill: &#129;
Mismatch: &#130; - mbstring: ‚; polyfill: &#130;
Mismatch: &#131; - mbstring: ƒ; polyfill: &#131;
Mismatch: &#132; - mbstring: „; polyfill: &#132;
Mismatch: &#133; - mbstring: …; polyfill: &#133;
Mismatch: &#134; - mbstring: †; polyfill: &#134;
Mismatch: &#135; - mbstring: ‡; polyfill: &#135;
Mismatch: &#136; - mbstring: ˆ; polyfill: &#136;
Mismatch: &#137; - mbstring: ‰; polyfill: &#137;
Mismatch: &#138; - mbstring: Š; polyfill: &#138;
Mismatch: &#139; - mbstring: ‹; polyfill: &#139;
Mismatch: &#140; - mbstring: Œ; polyfill: &#140;
Mismatch: &#141; - mbstring: ; polyfill: &#141;
Mismatch: &#142; - mbstring: Ž; polyfill: &#142;
Mismatch: &#143; - mbstring: ; polyfill: &#143;
Mismatch: &#144; - mbstring: ; polyfill: &#144;
Mismatch: &#145; - mbstring: ‘; polyfill: &#145;
Mismatch: &#146; - mbstring: ’; polyfill: &#146;
Mismatch: &#147; - mbstring: “; polyfill: &#147;
Mismatch: &#148; - mbstring: ”; polyfill: &#148;
Mismatch: &#149; - mbstring: •; polyfill: &#149;
Mismatch: &#150; - mbstring: –; polyfill: &#150;
Mismatch: &#151; - mbstring: —; polyfill: &#151;
Mismatch: &#152; - mbstring: ˜; polyfill: &#152;
Mismatch: &#153; - mbstring: ™; polyfill: &#153;
Mismatch: &#154; - mbstring: š; polyfill: &#154;
Mismatch: &#155; - mbstring: ›; polyfill: &#155;
Mismatch: &#156; - mbstring: œ; polyfill: &#156;
Mismatch: &#157; - mbstring: ; polyfill: &#157;
Mismatch: &#158; - mbstring: ž; polyfill: &#158;
Mismatch: &#159; - mbstring: Ÿ; polyfill: &#159;

While many of these are control characters (and the native function does return them), the single quote (dec 39) is particularly problematic.

View more
1 comment
cpeel

cpeel

18th Mar 2021 @ 04:11

help wanted

This will probably be a component to search and select an image from unsplash.

View more
joedixon

joedixon

12th Oct 2021 @ 19:59

help wanted

Octane Version

2.8.1

Laravel Version

10.48.28

PHP Version

8.3.16

What server type are you using?

Swoole

Server Version

6.0.1

Database Driver & Version

No response

Description

I'm using Envoyer to deploy a Laravel Octane application, taking advantage of its zero-downtime deployment features.

However, Octane currently does not support zero-downtime deployment because it does not follow symlink directories. It always remains in the actual directory (instead of the symlinked one) where the Octane server was initially started. When the outdated release directory is deleted, Octane continues running in that location, causing errors on every request and resulting in 500 response codes on the live application.

Error thrown:

Warning: require(/var/www/domain.com/releases/202502010200023/vendor/laravel/octane/bin/bootstrap.php): Failed to open stream: No such file or directory in /var/www/domain.com/releases/202502010200023/vendor/laravel/octane/bin/swoole-server on line 18
Fatal error: Uncaught Error: Failed opening required '/var/www/domain.com/releases/202502010200023/vendor/laravel/octane/bin/bootstrap.php' (include_path='.:/usr/bin/[email protected]/8.3.16/share/[email protected]/pear') in /var/www/domain.com/releases/202502010200023/vendor/laravel/octane/bin/swoole-server:18
Stack trace:
#0 /var/www/domain.com/releases/202502010200023/vendor/laravel/octane/bin/swoole-server(95): {closure}(Array)
#1 [internal function]: {closure}(Object(Swoole\Http\Server), 0)
#2 /var/www/domain.com/releases/202502010200023/vendor/laravel/octane/bin/swoole-server(170): Swoole\Server->start()
#3 {main}
  thrown in /var/www/domain.com/releases/202502010200023/vendor/laravel/octane/bin/swoole-server on line 18
#1 [internal function]: {closure}(Object(Swoole\Http\Server), 1)
#1 [internal function]: {closure}(Object(Swoole\Http\Server), 3)
#1 [internal function]: {closure}(Object(Swoole\Http\Server), 2)
#1 [internal function]: {closure}(Object(Swoole\Http\Server), 4)
#1 [internal function]: {closure}(Object(Swoole\Http\Server), 5)

Steps To Reproduce

Use any 0-downtime deployment or test it manually using the following instructions:

  1. Use the Swoole driver as an example.
  2. cd one directory up from the project's base path.
  3. Create a current symlink directory for your project using the command: ln -nsf ./octane-project-test ./current
  4. Start the Octane server: php ./current/artisan octane:start
  5. Copy your project to another directory: cp -R ./octane-project-test ./octane-project-test-new
  6. Activate the new release: ln -nsf ./octane-project-test-new ./current
  7. Reload the Octane server: php ./current/artisan octane:reload
  8. Remove the original project directory: rm -rf ./octane-project-test
View more
23 comments 👍 1 👀 2
mikkpokk

mikkpokk

2nd Mar 2025 @ 01:35

help wanted

Octane Version

2.11.0

Laravel Version

12.20.0

PHP Version

8.3.23

What server type are you using?

FrankenPHP

Server Version

1.8.0

Database Driver & Version

No response

Description

I have an octane app running inside a docker container and use a bind mount for the application code. When editing files, fs events are not sent across the bind mount to the container, so the watcher does not detect them. I have the same issue reported in #487. There is also an open issue on the frankenphp repository https://github.com/php/frankenphp/issues/1616.

A potential solution would be to add an option to octane:frankenphp, like --chokidar to use chokidar instead of frankenphp's watcher.

Steps To Reproduce

Same as #487, but using frankenphp.

View more
5 comments 🚀 1
rty765

rty765

14th Jul 2025 @ 19:46

enhancement help wanted

Discussed in https://github.com/spatie/schema-org/discussions/202

Originally posted by indyjonesnl January 10, 2024

$lodgingBusiness = Schema::lodgingBusiness()
  ->openingHours(
    Schema::openingHoursSpecification()
      ->dayOfWeek([Schema::dayOfWeek()::Monday])
      ->opens(new DateTime('09:00:00'))
      ->closes(new DateTime('17:00:00'))
  )
  ->checkinTime(new DateTime('14:00:00'))
  ->checkoutTime(new DateTime('11:00:00'))

This results in the current date + time being included in the output "opens":"2024-01-10T09:00:00+00:00","closes":"2024-01-10T17:00:00+00:00" and ..."checkinTime":"2024-01-10T14:00:00+00:00","checkoutTime":"2024-01-10T11:00:00+00:00"...

While the Schema should contain only the time, formatted as 14:30:00+08:00.

Can someone point me in the right direction?

View more
2 comments 👍 1
Gummibeer

Gummibeer

11th Jan 2024 @ 13:12

help wanted

Sulu CMS separates its assets into assets/admin and assets/website, this means when installing Encore within a Sulu CMS install you will have to change a bunch of paths: https://docs.sulu.io/en/latest/cookbook/webpack-encore.html

This isn't my main issue, I think this is acceptable for an initial setup. But I do think we can improve what happens when you composer require a symfony bundle that provides stimulus controllers.

In the Sulu + Encore setup, the controllers.json file lives in assets/website/controllers.json. But since this path is hardcoded here:

https://github.com/symfony/flex/blob/441f671b86a1b651e969dbc380bfee05e004780f/src/PackageJsonSynchronizer.php#L166-L170

The controllers.json is not updated automatically and there's no output telling you to manually do this either. So you're left a little lost in what is still missing. Also, figuring out what to manually add in controllers.json is quite tricky since most existing UX bundles don't document this manual setup.

Before I start hacking away at a PR, any suggestions how we can solve this properly? Or do we accept that this is not configurable and those who use custom paths just have to deal with it?

Thank you in advance.

View more
4 comments 👍 1
rskuipers

rskuipers

27th Dec 2022 @ 21:16

help wanted

In raising this issue, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked the pull requests tab for existing solutions/implementations to my issue/suggestion.
  • I have checked that the bug-fix I am reporting can be replicated.

Description of the problem

One of the important reasons for using hyperscript is that it handles escaping of characters which are reserved in html. Which prevents XSS.

spatie/html-element does not do this. Mainly because it uses strings as intermediate format instead of an object representation of the DOM.

View more
6 comments 👍 4
Erikvv

Erikvv

1st Feb 2018 @ 02:19

enhancement help wanted good first issue

Describe the bug logUnguarded() works provided that $guarded is set explicitly in the model. If it is not set explicitly but globally set, say in AppServiceProvider using Model::unguard(); then nothing is logged.

To Reproduce

  1. remove $fillable and $guarded from a model that use uses LogsActivity
  2. call Model::unguard(); in AppServiceProvider in the boot method
  3. set
    public function getActivitylogOptions() : LogOptions
    {
        return LogOptions::defaults()->logUnguarded();
    }
  1. Make some changes to a model and save them

Expected behavior Some changed properties should be logged but none are

Versions (please complete the following information)

  • PHP: 8.1
  • Database: MySql
  • Laravel: 9.38
  • Package: larvel-activitylog
View more
1 comment
colinmackinlay

colinmackinlay

20th Nov 2022 @ 12:31

help wanted

Not PHPUnit 11 because we still need to support for PHP 8.1

e.g. at the moment we have stuff like:

  1. Symfony\Flex\Tests\Configurator\CopyFromPackageConfiguratorTest::testConfigureAndOverwriteFiles The at() matcher has been deprecated. It will be removed in PHPUnit 10. Please refactor your test to not rely on the order in which methods are invoked.

Help wanted 🙏

View more
nicolas-grekas

nicolas-grekas

23rd May 2025 @ 10:13

help wanted

Octane Version

2.6.1

Laravel Version

11.41.3

PHP Version

8.3

What server type are you using?

Roadrunner

Server Version

2024.3.2

Database Driver & Version

No response

Description

ok this is in the borderline to be a bug but i write it anyway.

i am deploying using deployer , i suppose will happen for any Zero Downtime Deployments.

/releases/99/
/releases/100/
/releases/101/ 

and then a symbolic link from the latest release to /current , all pretty standard.

the problem come when running artisan octane:start vendor/laravel/octane/src/Commands/StartRoadRunnerCommand.php

will set roadrunner server with '-o', 'server.command='.(new PhpExecutableFinder)->find().','.base_path(config('octane.roadrunner.command', 'vendor/bin/roadrunner-worker')),

where base_path(...) will resolve to /releases/101/ not to /current

so in next deployment e.g. (/releases/102/) , when we run artisan octane:reload it will still use old /releases/101/ source code (i checked and yes if i go back to /releases/101/ and make a change it will be present after artisan octane:reload).

the solution is very simple, in config/octane.php you just need to add:

    'roadrunner'=>[
        'command' => env('OCTANE_ROADRUNNER_WORKER_PATH', base_path('vendor/bin/roadrunner-worker')),
    ]

OCTANE_ROADRUNNER_WORKER_PATH=../../current

would be nice is this added to config/octane.php , and maybe don't use base_path

or even better a option to provide the path in octane:start

Steps To Reproduce

deploy a octane laravel app using deployer , octane:reload will not work as expected

View more
1 comment
inikoo

inikoo

13th Feb 2025 @ 14:32

enhancement help wanted
  • standard tags
  • input fields
  • components
  • patterns

Add code snippets for each block

View more
👍 1
willemvb

willemvb

25th Jul 2016 @ 12:49

help wanted

Laravel Version

12.35.0

PHP Version

PHP 8.4.5 (cli) (built: Mar 12 2025 12:17:53) (NTS Visual C++ 2022 x64)

Database Driver & Version

No response

Description

When using Redis as the cache driver, Laravel normally prepends the configured cache prefixes (from CACHE_PREFIX or config/cache.php) to all keys stored in Redis.

However, when running parallel tests (using Laravel’s built-in parallel testing feature), the same cache operations do not include these prefixes if process "token" is appended with the user cache key (i.e. appending "token" to "spatie/laravel-permission" cache key so that each process has its own key), resulting in keys being stored without the expected prefix.

This creates a conflict or data leakage risk — particularly in environments where multiple Laravel applications share a Redis instance and run test suites concurrently.

Normal runtime behavior: Cache::put('example_key', 'foo');

Redis key stored: myapp-database-my-app-cache-user-key

Parallel test behavior: When the same code executes in a parallel test process (spawned via php artisan test --parallel): Cache::put('example_key', 'foo');

🚫 Redis key stored: key

— missing the expected Laravel cache prefix (myapp-database-my-app-cache-).

⚠️ Why it’s problematic

Prefixes are essential to namespace cache keys between environments or apps.

In CI environments (e.g., GitHub Actions, shared Redis server), multiple parallel test runners or multiple Laravel apps may use the same Redis instance, causing:

Cache key collisions Test flakiness Cross-application data leakage

🔍 Environment details

Cache driver: redis Testing mode: Laravel Parallel Testing (--parallel) Redis client: PhpRedis OS : Windows 11 Pro Redis 5.0.14.1 - 64 bit

✅ Expected behavior

Even in parallel testing, Laravel should apply the same Redis cache key prefixing logic as it does during normal runtime.

That means, regardless of whether the cache is accessed in the main process or a parallel test process, the Redis key should consistently include:

{myapp-database}-{my-app-cache}-user-key

🧠 Possible cause

It appears that the parallel testing process bootstraps a minimal application context, and the cache store may not inherit the configured prefix from config/cache.php or .env.

This causes RedisStore::buildKey() to skip or use an empty prefix.

💡 Suggested fix

Ensure that each parallel test process:

Loads and applies the same cache prefix configuration (config/cache.php), and

Initializes Redis cache stores with the correct prefix value from config.

This would maintain consistent cache behavior between normal runtime and parallel testing.

Steps To Reproduce

Use Redis as the cache driver (CACHE_DRIVER=redis).

Add to a test case:

test('redis prefix test', function () { Cache::put('example_key', 'foo'); });

Run: php artisan test

→ Redis key includes prefix ✅

Run: php artisan test --parallel

→ Redis key missing prefix

View more
1 comment
naveedali8086

naveedali8086

30th Oct 2025 @ 06:55

help wanted findapr

Hello,

Is it possible to close a flash message by clicking on it and not just on clicking on the cross? If so, how to achieve it?

Regards, Fred

View more
frdemoulin

frdemoulin

13th Aug 2025 @ 20:21

help wanted
View more
1 comment
julianstolp

julianstolp

11th Mar 2025 @ 14:11

enhancement help wanted hacktoberfest

Found the \Illuminate\Database\Eloquent\Concerns\HasAttributes::originalIsEquivalent() method during code diving and it should be usable for our trait! 🎉 This PR would be mainly reasearch when that method was added, if it's compatible with our version support rules and switching our own change detection logic with the core one.

View more
3 comments
Gummibeer

Gummibeer

20th Oct 2021 @ 10:03

Feature help wanted

Calling for help from Docker experts. We need to create the best possible docker-compose.yml file for this project. The application requirements are well defined (we use env vars, Webpack Encore, PHP 7.1, Symfony 4.1, SQLite database, etc.) so it should be possible to create that file.

View more
30 comments 👍 28
javiereguiluz

javiereguiluz

21st May 2018 @ 09:37

help wanted

Hello,

I noticed that there is an incompatibility with the mbstring polyfill and PHP 8.1 / Alpine Linux, which breaks a lot of my projects as soon as the php81-mbstring is not installed, but php81-iconv is installed:

Example:

Warning: iconv(): Wrong encoding, conversion from "ASCII" to "UTF-8//IGNORE" is not allowed in phar:///var/www/localhost/htdocs/phpstan.phar/vendor/symfony/polyfill-mbstring/Mbstring.php on line 736

It looks like //IGNORE is not accepted since echo iconv('UTF-8', 'UTF-8', 'test'); works, while echo iconv('UTF-8', 'UTF-8//IGNORE', 'test'); doesn't

View more
2 comments 👍 1
danielmarschall

danielmarschall

7th Jan 2022 @ 00:12

help wanted

Currently you can only see the latest 3 articles, latest 5 threads and latest 5 replies of a user on their profile. It would be cool if we could paginate through those results. We already use livewire so would be cool if we could add some magic with that.

View more
driesvints

driesvints

10th Sep 2025 @ 19:37

help wanted
View more
3 comments
joedixon

joedixon

12th Oct 2021 @ 19:56

help wanted

NotOrm Package

The goal is to make abstract code based on the package notorm to build a new orm system

View more
ambroisehdn

ambroisehdn

15th Jun 2022 @ 12:34

documentation help wanted good first issue

Provide updates to new functionalities in the v2 of the package.

View more
kwakuOfosuAgyeman

kwakuOfosuAgyeman

5th Jan 2025 @ 05:45

help wanted

I would be good to support normalizer_get_raw_decomposition function that appeared in PHP 7.3. I've tried to implement it but seems that existing decomposition data is already optimized to get the final decomposition. Example test case is available here. Pinging @nicolas-grekas as he is the author of Normalizer polyfill.

View more
4 comments
IonBazan

IonBazan

12th May 2018 @ 23:26

good first issue help wanted

Hello,

if you plan an scheduled maintenance with an START and END date it will never appear on the dashboard. Only if you create them with an START date only it will appear. I think this is a bit confusing, because if i plan an schedule an weekly update, i want to declare an timeslot and dont want to enter again the cachet-scheduled-maintenance to enter an date at the end of my maintenance.

Can this function be controlled or changed?

Thanks

View more
5 comments
kash1983

kash1983

27th Jan 2025 @ 09:33

help wanted

When encountering nested tokens, they are parsed only during formatting, not when compiling the pattern. And the type of tokens are validated only during the rendering as well. But the native implementation detects such error during the instantiation: https://3v4l.org/Sf69D This means that the error handling required for the polyfill is not the same than for the native implementation.

View more
stof

stof

23rd Oct 2018 @ 15:58

good first issue

Dashboard showing Operational

Image

Front end showing no issues, but the status seems to still be linked to the incident even if it's closed as fixed

Image

Image

Image

View more
4 comments 👍 1
glipschitz

glipschitz

25th Jan 2025 @ 11:01

help wanted

Bug description

Currently, the plugin calculates width/height incorrectly when swapping aspect ratios, leading to incorrect HTML output. When changing the aspect ratio of an image, the longest side should remain fixed, and the other side should be calculated accordingly.

How to reproduce

For an image of 3000x1688px as a source:

{{ responsive:image ratio="16/9" md:ratio="9/16" }}

it returns:

<picture>
    <source [...] >
    <source [...] >
    <source [...] >
    <img src="/img/asset/hash/image.jpg?w=3000&amp;h=1688&amp;s=9358bb54be5d388a9a2529a4196dcfc6" alt="" width="3000" height="1688">
</picture>

Now for the same image as source but with:

{{ responsive:image ratio="9/16" md:ratio="16/9" }}

it returns:

<picture>
    <source [...] >
    <source [...] >
    <source [...] >
    <img src="/img/asset/hash/image.jpg?w=3000&amp;h=5333&amp;s=6c5c0bb8447dbd7ff61a692f98b5f46d" alt="" width="3000" height="5333">
</picture>

The calculated aspect ratio is correct, but the dimensions are not. The generated values exceed the original image size.

In this last example, the correct height should be 3000px, and the width should be 1688px to ensure the image stays within its original dimensions.

Environment

Environment
Application Name: local
Laravel Version: 11.41.3
PHP Version: 8.3.14
Composer Version: 2.8.5
Environment: development
Debug Mode: ENABLED
URL: local.test
Maintenance Mode: OFF
Timezone: Europe/Paris
Locale: en

Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: CACHED

Drivers
Broadcasting: null
Cache: file
Database: sqlite
Logs: stack / single
Mail: smtp
Queue: redis
Session: file

Statamic
Addons: 3
Sites: 1
Stache Watcher: Disabled (auto)
Static Caching: Disabled
Version: 5.46.0 PRO

Statamic Addons
rias/statamic-redirect: 3.9.3
spatie/statamic-responsive-images: 5.2.1
statamic/seo-pro: 6.5.0

Installation

Fresh statamic/statamic site via CLI

Antlers Parser

regex (default)

View more
👍 1
jimblue

jimblue

3rd Feb 2025 @ 23:33

help wanted

Laravel Version

12.37.0

PHP Version

8.3

Database Driver & Version

No response

Description

I’ve noticed that both the CacheFailedOver and QueueFailedOver events in Laravel are triggered with every cache read or queue operation, even if there isn't an actual failover happening. This could lead to unnecessary event firing, especially in high-traffic systems, where it might cause excess logging, notifications, or processing.

Suggested Improvement: It would be really helpful if these events were only triggered when a true failover occurs. For instance, when the primary cache or queue connection fails, and Laravel falls back to the secondary connection, that’s when the event should fire. This would make the events more meaningful, reducing the noise caused by cache or queue operations that don’t actually involve failovers.

Use Case: Reducing Unnecessary Events: It would be great if events were only triggered when there’s an actual failover, which would help minimize unnecessary logging.

Improved Performance: This change would help prevent unnecessary system overhead from processing events during normal operations.

Clearer Monitoring: Triggering the events only when the fallback happens would make monitoring more accurate and provide more meaningful alerts.

Current Behavior: Right now, the events seem to fire every time a cache or queue operation takes place, regardless of whether the system is actually falling back to a secondary store.

Possible Solution: It might be useful for the events to be triggered only when there’s a real connection failure that leads to the fallback, rather than firing on every operation. This could help ensure the events are more focused and relevant.

Steps To Reproduce

Configure failover for cache/queue in .env:

CACHE_DRIVER=failover
QUEUE_CONNECTION=failover

Set up failover in config/cache.php and config/queue.php with redis as the primary store/connection and database as the fallback.

Simulate Redis failure (disconnect or stop Redis service).

Run a cache or queue operation (e.g., Cache::get('key') or dispatch a job).

Expected Behavior: The CacheFailedOver and QueueFailedOver events should only fire when an actual failover happens.

Current Behavior: The events fire on every cache/queue operation, even if no failover occurs.

View more
1 comment
anwarx4u

anwarx4u

12th Nov 2025 @ 09:42

help wanted

Currently, for plural rules, the MessageFormatter polyfills uses the English rules for all locales (it ignores the locale). To be consistent with what we do in symfony/intl (used by symfony/polyfill-intl-icu to implement NumberFormatter and DateFormatter), we should rather fail explicitly here (using the English rules for a different locale would not give the right result anyway)

View more
2 comments
stof

stof

23rd Oct 2018 @ 15:34

good first issue

There's no Expectation to expect a class to use HasRequestPagination rather than HasPagination.

View more
JonPurvis

JonPurvis

28th May 2025 @ 18:02

enhancement help wanted good first issue

using prompt engineering techniques provide enhancement to the Gemini service class in the Gemini prompt class, creating functions commonly used in Laravel applications.

View more
kwakuOfosuAgyeman

kwakuOfosuAgyeman

5th Jan 2025 @ 05:43

help wanted

Laravel Version

12.35

PHP Version

8.3.6

Database Driver & Version

Valkey 8.1

Description

When Trying to flush cache()->tags($tags)->flush(); when there very much keys under this tags, it fails to write the LUA scipt to the server becaude of buffer size, when using Predis in the Predis\Connection\StreamConnection:295 in the write function when perform fwrite($socket, $buffer) it return 0, I think the anser it to chunk the LUA script to chunks let's say 1000 keys in chunk

Steps To Reproduce

in laravel project run the code function test_tags_flush(array $tags){ foreach (range(1,5000) as $key => $value) { cache()->tags($tags)->put("key:{$key}", "value:{$value}", 300); } cache()->tags($tags)->flush(); }

test_tags_flush(['test-tags-flush']);

View more
3 comments
MoishyTlushTakin

MoishyTlushTakin

26th Oct 2025 @ 09:11

bug help wanted

When attempting to filter tests by test or file name pressing the "Enter" key has no effect.

Pressing "Enter" at the default screen correctly triggers a "test run" where all tests are run.

View more
4 comments
ntwb

ntwb

25th Feb 2018 @ 10:49

Bug help wanted

The friendly-errors-webpack-plugin has a built-in transformer/formatter for when a module is missing. To see the behavior, try (in any JavaScript file):

require('foo'); // foo is not a module that is installed

The error is:

This dependency was not found:

  • foo in ./app/Resources/assets/js/app.js To install it, you can run: npm install --save foo

The problem is the npm install part... which should be yarn add to avoid confusion with our users. There is an issue about this: https://github.com/geowarin/friendly-errors-webpack-plugin/issues/33

View more
2 comments
weaverryan

weaverryan

25th Jun 2017 @ 23:10

help wanted findapr

Description: I am using Flasher 2.0.1 in my Laravel 11 project and would like to know how to properly use the Flasher library in JavaScript. Additionally, I want to ensure that the JavaScript configuration is consistent with the settings defined in the flasher.php configuration file.

Details: Flasher Version: 2.0.1 Laravel Version: 11 Problem: Need guidance on using the Flasher library with JavaScript in a way that mirrors the configuration set in flasher.php.

View more
raseldev99

raseldev99

16th Sep 2024 @ 04:50

help wanted findapr

Hi Developer,

I appreciate your work on this project—it's really well-built and helpful for developers like me. I recently implemented it and found it working great.

However, I noticed that the .fl-wrappe class currently has z-index: 10, which causes it to appear under the header when using a fixed or sticky header. I suggest updating it to z-index: 99999 to ensure proper visibility.

Thanks for your efforts and for sharing this project!

Best regards, Md. Jahangir Alam Rohan.

View more
1 comment 🎉 1
rohan9222

rohan9222

18th Feb 2025 @ 04:20

enhancement help wanted

Hi! If I use this package with my project I has a problem. My package.json has a "git dependency" like this:

{
  "peerDependencies": {
    "package": "git+ssh://[email protected]/team/project.git"
  }
}

And npm-install-peers breaks.

View more
👍 5
JWo1F

JWo1F

18th Dec 2017 @ 08:52

help wanted
View more
weaverryan

weaverryan

10th Jan 2024 @ 19:05

help wanted

Hi,

With the polyfill, var_dump(mb_strlen(chr(254))) return 0. With the php8.0-mbstring extension, var_dump(mb_strlen(chr(254))) return 1;

versions : * v1.26.0

Thanks, Alex

View more
7 comments
alexchuin

alexchuin

18th Oct 2022 @ 12:51

help wanted

Bug description

Chrome, Firefox, and Safari now support setting the width and height attributes on <source> elements within <picture> elements. You can read more about this in the web.dev article on optimizing CLS. This enhancement allows browsers to better handle layout shifts and varying aspect ratios for responsive images.

How to reproduce

Current Behavior:

Currently, Statamic Responsive Images does not take advantage of this browser capability. As a result, when multiple sources are provided, the appropriate width and height attributes are not applied to <source> elements, which may lead to layout shifts due to varying aspect ratios.

Proposed Enhancement:

Set appropriate width and height attributes on <source> elements based on their aspect ratios.

Benefits:

  • Improved Visual Stability: Reduce Cumulative Layout Shift (CLS) by providing browsers with the correct dimensions upfront.
  • Better Performance: Modern browsers can allocate the correct space for images during page load.
  • Enhanced Responsiveness: Accurately reflect different image aspect ratios for a more consistent user experience.

Environment

Environment
Application Name: local
Laravel Version: 11.41.3
PHP Version: 8.3.16
Composer Version: 2.8.5
Environment: development
Debug Mode: ENABLED
URL: local.test
Maintenance Mode: OFF
Timezone: Europe/Paris
Locale: en

Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: NOT CACHED

Drivers
Broadcasting: null
Cache: file
Database: sqlite
Logs: stack / single
Mail: smtp
Queue: redis
Session: file

Statamic
Addons: 3
Sites: 1
Stache Watcher: Disabled (auto)
Static Caching: Disabled
Version: 5.46.1 PRO

Statamic Addons
rias/statamic-redirect: 3.9.3
spatie/statamic-responsive-images: 5.2.1
statamic/seo-pro: 6.5.0

Installation

Fresh statamic/statamic site via CLI

Antlers Parser

regex (default)

Additional details

Leveraging native width and height support on <source> elements can lead to significant improvements in layout stability and overall performance on modern browsers. This enhancement would allow the package to better handle responsive images by using up-to-date browser capabilities.

Thanks for considering this enhancement!

View more
2 comments 👍 1
jimblue

jimblue

7th Feb 2025 @ 22:03

good first issue

I would love to see support for oAuth in Catchet. I know there are some other (closed) issues requesting the same functionality, but I think this would be a great addition for Catchet.

View more
3 comments 👍 1
FoksVHox

FoksVHox

28th Feb 2025 @ 08:29