Let's try out Filament and move our own admin panels to it. This should provide us with a much more powerful admin backend.
Found 58 issues
First time here? 👋
Welcome to Find a PR.
Find a PR is an open-source site that is built to help developers find projects so that they can submit their very first pull request.
If you're a contributor looking to find a project to contribute to, feel free to browse through the list below.
If you're a maintainer looking to list your project on Find a PR, you can read how to do this in the documentation.
We are logging activity of several models, some using SoftDeletes trait and others not.
When we set config option 'subject_returns_soft_deleted_models' => true
then calling subject()
on any model not using SoftDeletes trait throws an exception: Call to undefined method Illuminate\Database\Eloquent\Builder::withTrashed()
.
Can the subject()
method below be made to check first whether the Model uses the SoftDeletes trait? Or perhaps check whether withTrashed()
is a defined method on the Model? I tried a few things but couldn't figure out how to get the class of the Model..
bluec
7th Nov 2018 @ 13:44
Describe the bug
When you attempt to dump a binary string or anything containing one (like an array or an object), Ray does not dump anything. It just fails silently.
Versions
Ray version (you can see this in "About Ray"): 2.8.1
You can use composer show
to get the version numbers of:
- spatie/ray package version: 1.41.2
- spatie/laravel-ray package version (if applicable): 1.37.1
PHP version: 8.2.17 Laravel version (if applicable): 11.18.1
To Reproduce
Add this in your code:
ray(hex2bin('ae0f3d'));
Expected behavior
Ray should display this (like the console when dump
is used):
b"®\x0F="
Desktop (please complete the following information):
- OS: MacOs
- Version: 14.6.1
sebj54
27th Aug 2024 @ 14:57
The goal is to make abstract code based on the package notorm to build a new orm system
ambroisehdn
15th Jun 2022 @ 12:34
As an extension of https://github.com/cachethq/core/issues/93 it'd be cool to have an option that shows completed schedules in the incident timeline.
jbrooksuk
24th Nov 2024 @ 15:42
When encountering nested tokens, they are parsed only during formatting, not when compiling the pattern. And the type of tokens are validated only during the rendering as well. But the native implementation detects such error during the instantiation: https://3v4l.org/Sf69D This means that the error handling required for the polyfill is not the same than for the native implementation.
stof
23rd Oct 2018 @ 15:58
Figure our a way to show a grayed out Laravel logo as a default avatar instead of the current default GitHub one.
driesvints
29th Sep 2021 @ 10:48
Octane Version
2.6.2
Laravel Version
11.16.0
PHP Version
8.3.6
What server type are you using?
Swoole
Server Version
5.1.2
Database Driver & Version
No response
Description
Before i start, this is not a duplicate to https://github.com/laravel/octane/issues/903, this is about Swoole. Also large stream responses are fixed with https://github.com/laravel/octane/issues/636, but not this case.
While using Storage::download or Storage::response, laravel is creating a stream response that uses php fpassthru($stream). Somehow the buffering between fpassthru and ob_start does not work, instead it tries to load the full file into the memory. This leads to out of memory errors while downloading very big files.
If i replace the fpassthru with a fread-while-loop it is working as expected.
I can basically make a pull request, but need help with the solution... Is this more a problem in the laravel framework or PHP itself?
Steps To Reproduce
- Write a laravel controller that uses Storage::download() to download file with e.g. 1 GB
- Call the controller and see the out of memory error
NiroDeveloper
24th Jul 2024 @ 11:18
We can't seem to upgrade to v3 because they removed the ability to output images as responses: https://image.intervention.io/v3/introduction/upgrade
We'll need to figure out a new way to generate social images.
driesvints
22nd Nov 2024 @ 15:16
We need to bring back the various notifications sent by Cachet.
-
Components
-
ComponentStatusChanged
-
-
Incidents
-
NewIncident
-
-
Incident Updates
-
IncidentUpdated
(this could be moved into theIncidents
namespace above.
-
-
Schedule
-
NewSchedule
-
-
Subscriber
-
VerifySubscription
-
-
System
-
Test
-
jbrooksuk
13th Sep 2023 @ 18:59
Hi,
With the polyfill, var_dump(mb_strlen(chr(254)))
return 0
.
With the php8.0-mbstring extension, var_dump(mb_strlen(chr(254))) return 1
;
versions : * v1.26.0
Thanks, Alex
alexchuin
18th Oct 2022 @ 12:51
What happened?
After installation, I noticed that in the browser console it outputs an error of wireEl is undefined.
How to reproduce the bug
Just install this package in a livewire project, preferable with Filament's admin package. And see the browser console.
composer create-project laravel/laravel test;
composer require filamentphp/filament;
composer require spatie/laravel-blade-comments;
Then go through the browser console and see the error
Package Version
1.0.1
PHP Version
8.2.0
Laravel Version
10.13.0
Which operating systems does with happen with?
macOS
Notes
Filament ......................................................
Packages ...... filament, forms, notifications, support, tables
Version .............................................. v2.17.44
Views ..................................... PUBLISHED: filament
sawirricardo
2nd Jun 2023 @ 07:15
I would be good to support normalizer_get_raw_decomposition function that appeared in PHP 7.3. I've tried to implement it but seems that existing decomposition data is already optimized to get the final decomposition. Example test case is available here.
Pinging @nicolas-grekas as he is the author of Normalizer
polyfill.
IonBazan
12th May 2018 @ 23:26
Currently, for plural rules, the MessageFormatter polyfills uses the English rules for all locales (it ignores the locale).
To be consistent with what we do in symfony/intl
(used by symfony/polyfill-intl-icu
to implement NumberFormatter and DateFormatter), we should rather fail explicitly here (using the English rules for a different locale would not give the right result anyway)
stof
23rd Oct 2018 @ 15:34
It should be possible to report an incident and attach components (with statuses) to incidents in a single API request.
jbrooksuk
24th Dec 2024 @ 12:16
Octane Version
v2.3.10
Laravel Version
v11.6.0
PHP Version
v8.3.6
What server type are you using?
FrankenPHP
Server Version
v1.1.4 PHP 8.3.6 Caddy v2.7.6
Database Driver & Version
Postgress
Description
Last week we updated our app previously using php-fpm
running on Forge to use Laravel Octane with FrankenPHP. Our site is mostly an API that handles analytics events (Like google analytics). It uses the default Laravel api
throttling.
In staging our app worked fine (30 req/sec same IP), but when deploying to production (1400 req/sec, different IPs) it started to fail, giving a lot of 429 Too Many Requests.
I quickly rolled back to php-fpm
and after a few hours tried again with the same problem. Rolled back and the next day I switched to Swoole and it worked perfectly without changing a single line of code nor having to redeploy anything. So I can confidently say that is NOT a bug in my code, but rather a bug with FrankenPHP or the Octane integration with FrankenPHP.
My theory is that the RateLimiter is not reseting between requests so it's shared between different users. So multiple different users trigger the rate limiter:
This is my Rate limiter configuration:
// AppServiceProvider
RateLimiter::for('api', function (Request $request) {
return Limit::perMinute(60)->by($request->user()?->id ?: $request->ip());
});
our production CACHE_STORE
is redis
. Throttling worked perfectly fine without octane and with octane but using Swoole. It failed with hundred of 429 Too Many Requests after installing FrankenPHP.
This is our bootstrap/app.php
:
<?php
use Illuminate\Foundation\Application;
use Illuminate\Foundation\Configuration\Exceptions;
use Illuminate\Foundation\Configuration\Middleware;
use Illuminate\Support\Facades\App;
return Application::configure(basePath: dirname(__DIR__))
->withRouting(
commands: __DIR__.'/../routes/console.php',
health: '/up',
then: function () {
Route::middleware('api')
->prefix('api')
->as('api.')
->domain(config('app.domain'))
->group(base_path('routes/api.php'));
Route::middleware('web')
->domain(config('app.domain'))
->group(base_path('routes/web.php'));
Route::middleware('web')
->domain(config('playsaurus.ads.domain'))
->group(base_path('routes/ads.php'));
}
)
->withMiddleware(function (Middleware $middleware) {
$middleware->throttleApi();
$middleware->redirectTo(
guests: '/login',
users: '/',
);
$middleware->web(append: [
\App\Http\Middleware\HandleInertiaRequests::class,
\Illuminate\Http\Middleware\AddLinkHeadersForPreloadedAssets::class,
]);
$middleware->api(append: [
\App\Http\Middleware\ConfigureLocale::class,
]);
$middleware->alias([
'localize' => \App\Http\Middleware\ConfigureLocale::class,
'embed' => \App\Http\Middleware\AllowsEmbeding::class,
]);
})
->withExceptions(function (Exceptions $exceptions) {
$exceptions->dontReport([
\App\Services\Announcements\InvalidVariantKey::class,
\App\Exceptions\CouponRedeemException::class,
]);
})->create();
Steps To Reproduce
It's difficult to reproduce. Because I can't test it in production because that would mean a lot of downtime for our users.
My theory is that it would be possible to reproduce from multiple different IPs. But since I don't have the means to test it, I don't know.
jhm-ciberman
14th May 2024 @ 00:15
This is a big one, but would resolve https://github.com/cachethq/cachet/issues/4425
- Opt components into being monitored.
- Needs some kind of configuration (what if a Header is required to access the URL? Frequency?)
- Add a cron job that runs every minute and checks the actively components.
- Track component availability.
- Dashboard to manage component monitors, track availability etc.
- API
jbrooksuk
4th Jan 2025 @ 18:12
v2.4 allows users to add Google 2FA to their account for an added layer of security. 3.x should also implement this in some way.
Things to consider
- How to generate the code
- How do verify via 2FA when this is enabled on a users account.
- Can admins reset 2FA for a user if they've lost their 2FA device?
- How should backup codes work?
joelbutcher
15th Jan 2025 @ 18:25
Discussed in https://github.com/spatie/schema-org/discussions/202
Originally posted by indyjonesnl January 10, 2024
$lodgingBusiness = Schema::lodgingBusiness()
->openingHours(
Schema::openingHoursSpecification()
->dayOfWeek([Schema::dayOfWeek()::Monday])
->opens(new DateTime('09:00:00'))
->closes(new DateTime('17:00:00'))
)
->checkinTime(new DateTime('14:00:00'))
->checkoutTime(new DateTime('11:00:00'))
This results in the current date + time being included in the output "opens":"2024-01-10T09:00:00+00:00","closes":"2024-01-10T17:00:00+00:00"
and ..."checkinTime":"2024-01-10T14:00:00+00:00","checkoutTime":"2024-01-10T11:00:00+00:00"...
While the Schema should contain only the time, formatted as 14:30:00+08:00
.
Can someone point me in the right direction?
Gummibeer
11th Jan 2024 @ 13:12
The docs aren't finished. This issue exists to track the missing pieces:
- App icons
- Context menus
- Dock
- Printing
- ProgressBar
- Queue
- Screens
- Settings
- Shell
- System
- Touch ID
- Testing
- Build signing (#361)
- macOS
- Windows
- How to customise Electron / PR to NativePHP
- Security disclosures process
- Highlight current section
- Show ToC persistently on the right-hand side
- Sponsorship page
- Contributors page
- Show sponsors in sidebar
- Add next/previous section buttons to the bottom of pages
- Add Edit on GitHub link to pages
simonhamp
8th Sep 2024 @ 15:01
Describe the bug
logUnguarded()
works provided that $guarded
is set explicitly in the model. If it is not set explicitly but globally set, say in AppServiceProvider
using Model::unguard();
then nothing is logged.
To Reproduce
- remove
$fillable
and$guarded
from a model that use usesLogsActivity
- call
Model::unguard();
inAppServiceProvider
in theboot
method - set
public function getActivitylogOptions() : LogOptions
{
return LogOptions::defaults()->logUnguarded();
}
- Make some changes to a model and save them
Expected behavior Some changed properties should be logged but none are
Versions (please complete the following information)
- PHP: 8.1
- Database: MySql
- Laravel: 9.38
- Package: larvel-activitylog
colinmackinlay
20th Nov 2022 @ 12:31
When using the addToMediaFromURL method, I'm receiving a Could Not Load Image error on the server, but not locally (I'm using Laravel Vapor) and not with other image formats.
The code below is where the error is occuring and that code is receiving an absolute file path to the image in s3, which is available.
public function addToMediaLibrary($file_path) { $media = $this->addMediaFromUrl($file_path) ->toMediaCollection("", 's3'); return $media; }
As an example the file path when logged out is https://s3.sitesforsaas.com/tenants/d221c93a-3757-466c-bf83-b74a9ee64c04/sites/9cfc24c7-cb2a-4c5a-8c0f-73ecdc79c166/2024/09/4e9854b0-4f2d-4931-a726-01f557bd7fc6.webp
, but the error is looking for the image in local 'tmp' storage for some reason.
Could not load image at path
/tmp/storage/tenantd221c93a-3757-466c-bf83-b74a9ee64c04/media-library/temp/j7pNMerUdReNx9MfAG5rKjcmGHWu4i99/LM2UYMTcYU0BO8sLsTfeOBpS9eXximejlarge.webp`",
josiahmann
11th Sep 2024 @ 21:32
AST, or "abstract syntax tree", creates the expectation of a nested tree structure. In the case of a query string, the AST will only ever be one level deep; as multi nodes are combined into one.
If anyone wants to suggest a better, more clear name: you're welcome.
brendt
20th Dec 2018 @ 13:41
- standard tags
- input fields
- components
- patterns
Add code snippets for each block
willemvb
25th Jul 2016 @ 12:49
Q | A |
---|---|
Feature PR | symfony/symfony#59315 |
PR author(s) | @gr8b |
Merged in | 7.3 |
We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.
To fix this issue, please create a PR against the 7.3 branch in the symfony-docs repository.
Thank you! :smiley:
fabpot
2nd Jan 2025 @ 11:55
Describe the bug
I have a table which has an order
column. When I reorder the elements I update each model with the new order.
Because the table has some large JSON columns I select only id
and order
columns for efficiency. I set the new order and save the model.
foreach (Faq::query()->get(['id', 'order']) as $faq) {
$faq->order = $newOrder[$faq->id];
$faq->save();
}
The diffs created in the activity_log
table look like this:
{
"old": {
"order": 1,
"answer": null,
"question": null
},
"attributes": {
"order": 2,
"answer": "long JSON content",
"question": "long JSON content"
}
}
From what I see laravel-activitylog fetches the model with all columns from the database before creating a log entry which kind of defeats the purpose of my "select list optimization" and produces an incorrect diff.
Generally I want these large JSON columns to be logged in case a user changes them but in this case I only change the order
column so I would like to see only the order
column in the diff.
I have tried running these updates straight off the Eloquent builder:
Faq::query()->where('id', $id)->update(['order' => $newOrder[$id]]);
but in this case nothing is logged.
I have the following activitylog configuration for my models:
public function getActivitylogOptions(): LogOptions
{
return LogOptions::defaults()
->logAll()
->logOnlyDirty()
->logExcept([
'id',
'created_at',
'updated_at',
]);
}
To Reproduce Select a subset of columns from the database, change these columns, save the model and see that other (not initially selected) columns are present in the diff.
Expected behavior Only columns that've actually been changed should be present in the diff.
Versions
- PHP: 8.1
- Database: MySQL 8
- Laravel: 9.31.0
- Package: 4.6.0
KKSzymanowski
28th Sep 2022 @ 21:53
For some reason, our test suite is super slow. We should look into this and try to decrease memory usage and speed it up.
Parallel run:
Tests: 316 passed (785 assertions)
Duration: 13.64s
Parallel: 10 processes
Regular run:
Tests: 316 passed (785 assertions)
Duration: 96.30s
driesvints
29th Dec 2023 @ 10:43
It should be possible to configure Cachet via a cachet:install
Artisan command.
v2.x had an interactive command that would ask you questions and store the configuration.
For v3.x, this won't work exactly the same as we now have a mix of .env
and database settings, but the idea is the same.
jbrooksuk
9th Oct 2024 @ 20:21
Laravel Version
11.33.2
PHP Version
8.2.24
Database Driver & Version
No response
Description
Hi, I noticed that when I register an observers with the ObservedBy
attribute is not tracked by event:list
command while via observe method in an AppServiceProvider this is appropriately tracked.
Steps To Reproduce
- Create a model with an Observer
- Run
php artisan event:list
command - Check the different behavior based on the register mode
illambo
21st Nov 2024 @ 09:21
Description: I am using Flasher 2.0.1 in my Laravel 11 project and would like to know how to properly use the Flasher library in JavaScript. Additionally, I want to ensure that the JavaScript configuration is consistent with the settings defined in the flasher.php configuration file.
Details: Flasher Version: 2.0.1 Laravel Version: 11 Problem: Need guidance on using the Flasher library with JavaScript in a way that mirrors the configuration set in flasher.php.
raseldev99
16th Sep 2024 @ 04:50
Hello,
I noticed that there is an incompatibility with the mbstring polyfill and PHP 8.1 / Alpine Linux, which breaks a lot of my projects as soon as the php81-mbstring is not installed, but php81-iconv is installed:
Example:
Warning: iconv(): Wrong encoding, conversion from "ASCII" to "UTF-8//IGNORE" is not allowed in phar:///var/www/localhost/htdocs/phpstan.phar/vendor/symfony/polyfill-mbstring/Mbstring.php on line 736
It looks like //IGNORE
is not accepted since echo iconv('UTF-8', 'UTF-8', 'test');
works, while echo iconv('UTF-8', 'UTF-8//IGNORE', 'test');
doesn't
danielmarschall
7th Jan 2022 @ 00:12
Laravel Version
11.33.2
PHP Version
8.3.13
Database Driver & Version
MySQL
Description
I recently upgraded a legacy laravel application from 5.4 to laravel 11.
The following code:
$booking_boats = $this->current_location->booking_boats()
->with(['booking'])
->where(function ($query) {
$query->where('booking_boats.status','Queued')
->orWhere([
['booking_boats.status','=','On Water'],
['booking_boats.checkout_date','!=',''],
]);
})
->get();
Would previously generate a query like this:
SELECT *
FROM `booking_boats`
INNER JOIN `bookings`
ON `bookings`.`id` = `booking_boats`.`booking_id`
WHERE `bookings`.`deleted_at` is null
AND `bookings`.`location_id` = ?
AND (`booking_boats`.`status` = ? or (`booking_boats`.`status` = ? AND `booking_boats`.`checkout_date` != ?))
AND `booking_boats`.`deleted_at` is null
The important part is:
(booking_boats
.status
= ? AND booking_boats
.checkout_date
!= ?)
In Laravel 11, the following query is generated:
SELECT *
FROM `booking_boats`
INNER JOIN `bookings`
ON `bookings`.`id` = `booking_boats`.`booking_id`
WHERE `bookings`.`location_id` = ?
AND (`booking_boats`.`status` = ? or (`booking_boats`.`status` = ? or `booking_boats`.`checkout_date` != ?))
AND `booking_boats`.`deleted_at` is null
AND `bookings`.`deleted_at` is null
The important part is:
(booking_boats
.status
= ? or booking_boats
.checkout_date
!= ?)
So, previously using ->orWhere with an array syntax would generate an AND query, but now it generates an OR query.
This seems like a bug but if somehow I missed this in the laravel upgrade notes I would appreciate knowing what exactly was changed and what functions are impacted as there are hundreds of queries I will have to update.
Thank you.
Steps To Reproduce
Perform an ->orWhere using multiple array elements, ie:
$query->where('booking_boats.status','Queued')
->orWhere([
['booking_boats.status','=','On Water'],
['booking_boats.checkout_date','!=',''],
]);
stellar-scottreed
22nd Nov 2024 @ 00:55
using prompt engineering techniques provide enhancement to the Gemini service class in the Gemini prompt class, creating functions commonly used in Laravel applications.
kwakuOfosuAgyeman
5th Jan 2025 @ 05:43
Many of them are out of date, some by a few major versions!
It would be great to get these into good order and start keeping them up to date
simonhamp
24th Oct 2024 @ 11:53
We need to implement the metric charts into the status page.
jbrooksuk
5th Mar 2024 @ 16:00
When calling mb_convert_encoding()
with $fromEncoding === 'HTML-ENTITIES'
, the polyfill does not return functionally equivalent strings to the native function. This is because mb_convert_encoding()
uses html_entity_decode()
when $fromEncoding === 'HTML-ENTITIES'
and that function does not return characters for many numeric entities 0-31 and 127-159. For example:
<?php
require "vendor/symfony/polyfill-mbstring/Mbstring.php";
use Symfony\Polyfill\Mbstring as p;
for($i = 0; $i < 1024; $i++) {
$string = "&#" . $i . ";";
$mbstring = mb_convert_encoding($string, 'UTF-8', 'HTML-ENTITIES');
$polyfill = p\Mbstring::mb_convert_encoding($string, 'UTF-8', 'HTML-ENTITIES');
if($mbstring != $polyfill) {
echo "Mismatch: $string - mbstring: $mbstring; polyfill: $polyfill\n";
}
}
outputs:
Mismatch: � - mbstring: ; polyfill: �
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring:; polyfill: 
Mismatch:  - mbstring:
; polyfill: 
Mismatch:  - mbstring:
; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch: ' - mbstring: '; polyfill: '
Mismatch:  - mbstring: ; polyfill: 
Mismatch: € - mbstring: ; polyfill: €
Mismatch:  - mbstring: ; polyfill: 
Mismatch: ‚ - mbstring: ; polyfill: ‚
Mismatch: ƒ - mbstring: ; polyfill: ƒ
Mismatch: „ - mbstring: ; polyfill: „
Mismatch: … - mbstring:
; polyfill: …
Mismatch: † - mbstring: ; polyfill: †
Mismatch: ‡ - mbstring: ; polyfill: ‡
Mismatch: ˆ - mbstring: ; polyfill: ˆ
Mismatch: ‰ - mbstring: ; polyfill: ‰
Mismatch: Š - mbstring: ; polyfill: Š
Mismatch: ‹ - mbstring: ; polyfill: ‹
Mismatch: Œ - mbstring: ; polyfill: Œ
Mismatch:  - mbstring: ; polyfill: 
Mismatch: Ž - mbstring: ; polyfill: Ž
Mismatch:  - mbstring: ; polyfill: 
Mismatch:  - mbstring: ; polyfill: 
Mismatch: ‘ - mbstring: ; polyfill: ‘
Mismatch: ’ - mbstring: ; polyfill: ’
Mismatch: “ - mbstring: ; polyfill: “
Mismatch: ” - mbstring: ; polyfill: ”
Mismatch: • - mbstring: ; polyfill: •
Mismatch: – - mbstring: ; polyfill: –
Mismatch: — - mbstring: ; polyfill: —
Mismatch: ˜ - mbstring: ; polyfill: ˜
Mismatch: ™ - mbstring: ; polyfill: ™
Mismatch: š - mbstring: ; polyfill: š
Mismatch: › - mbstring: ; polyfill: ›
Mismatch: œ - mbstring: ; polyfill: œ
Mismatch:  - mbstring: ; polyfill: 
Mismatch: ž - mbstring: ; polyfill: ž
Mismatch: Ÿ - mbstring: ; polyfill: Ÿ
While many of these are control characters (and the native function does return them), the single quote (dec 39) is particularly problematic.
cpeel
18th Mar 2021 @ 04:11
Add in PHP 7.3 as Normalizer::normalize() argument for NFKC_Casefold normalization.
nicolas-grekas
7th Feb 2019 @ 10:11
Cachet 2.x can store custom meta data to be passed to incidents. We can extend this in 3.x to support custom meta on most, if not all models.
- Create
Meta
model. - Add Meta relationship to models.
- Update actions and API to support passing meta.
- Add meta to the Http resources.
jbrooksuk
14th Sep 2023 @ 18:51
We need to bring back support for tags.
- In 2.x only components support being tagged, but we could extend this to other areas including; incidents, metrics and schedules.
- The API needs to support filtering the endpoint by a tag.
jbrooksuk
13th Sep 2023 @ 20:45
When attempting to filter tests by test or file name pressing the "Enter" key has no effect.
Pressing "Enter" at the default screen correctly triggers a "test run" where all tests are run.
ntwb
25th Feb 2018 @ 10:49
We need a method of migrating users from 2.4 to 3.x.
Things to consider:
- Migrate settings
- Migrate resources
- Migrate subscriptions / subscribers
- Migrate API Keys
AOB (please add to this list)
As a comment on the latter, once #183 is merged, we'll need to programmatically migrate users 2.4 API Keys to 3.x using something like the following
$v2ApiKey = $v2User->api_key;
$v3User->tokens()->create([
'name' => 'v2.4 API Key',
'token' => hash('sha256', $v2ApiKey),
'abilities' => ['*'],
'expires_at' => now()->addDays(90),
]);
@jbrooksuk We need to decide on the abilities
and expires_at
. IMO it makes sense to throw something into the upgrade documentation that old 2.4 API Keys will continue to work for up to 90 days. But if they want to use the API after that, then they'll need to generate a new API Token using the 3.x dashboard.
joelbutcher
15th Jan 2025 @ 18:19
Octane Version
2.5.9
Laravel Version
11
PHP Version
8.3
What server type are you using?
Swoole
Server Version
8.3
Database Driver & Version
No response
Description
Wildcard paths like config/**/*.php
in the watch
array of config/octane.php
aren't working properly.
Steps To Reproduce
- Install chokidar
- Run
octane:start --watch
(I'm using Swoole) - Modify a file in the
config
directory. Octane won't restart - Change
config/**/*.php
toconfig
in thewatch
array ofconfig/octane.php
- Restart Octane server
- Modify a file in the
config
directory. Octane will now correctly restart
Same problem with anything else using wildcards eg. database
(try modifying a seeder to test).
binaryfire
14th Nov 2024 @ 11:57
What happened?
I just installed package and complement for AI powered solution. When I create an issue to test it I get :
I had to change the links function like this to make it work for me:
public function links(): array
{
$rawText = Str::finish($this->rawText, 'ENDLINKS');
$textLinks = $this->between('LINKS', 'ENDLINKS', $rawText);
$textLinks = explode(PHP_EOL, $textLinks);
$links = [];
foreach ($textLinks as $textLink) {
$textLink = str_replace('\\', '\\\\', $textLink);
$textLink = str_replace('\\\\\\', '\\\\', $textLink);
$decodedLink = json_decode($textLink, true);
if ($decodedLink !== null) {
$links[$decodedLink['title']] = $decodedLink['url'];
}
}
return $links;
}
How to reproduce the bug
When I install the package in my project and use it with AI powered
Package Version
1.0
PHP Version
8.2.14
Laravel Version
11.14
Which operating systems does with happen with?
Windows
Notes
No response
bestmomo
21st Jul 2024 @ 10:57
At the moment, if you have a job and you specified the number of times it should be retried, you could test it like this:
test('job')
->expect('App\Jobs\TestJob')
->toBeTriedAgainOnFailure()
However, that merely checks that a $tries
property exists on the class and that the value is above 1. I think it would be better if you could specify that number yourself:
test('job')
->expect('App\Jobs\TestJob')
->toBeTriedAgainOnFailure(maxTries: 5)
If you have a set number that each job should be retried across the application, then this test will help catch where someone has tried to increase it.
There's definitely some other expectations that this can be applied to and I think it will greatly enhance Lawman
JonPurvis
16th Sep 2024 @ 02:18
- Notifications should be sent to subscribers, depending on their subscription settings.
- If the settings disables subscriptions, then the “Subscribers” dashboard should be hidden.
- Need a new “Manage Notifications” settings dashboard to manage and test mail settings.
- Notifications should be sent in a queue.
- Manually adding subscribers:
- Force verification (should be a confirmation).
- Option to suppress notifications when an incident occurs within a scheduled maintenance period.
- Skip verifying of users. Not sure I’m a huge fan of this option…
jbrooksuk
3rd Oct 2024 @ 18:42
Found the \Illuminate\Database\Eloquent\Concerns\HasAttributes::originalIsEquivalent()
method during code diving and it should be usable for our trait! 🎉
This PR would be mainly reasearch when that method was added, if it's compatible with our version support rules and switching our own change detection logic with the core one.
Gummibeer
20th Oct 2021 @ 10:03
using prompt engineering techniques provide enhancement to the Claude service class in the Claude prompt class, creating functions commonly used in Laravel applications. For example, brand builder, seo product optimizer, video and or image captioner, automated chatbots #goodfirstissue
kwakuOfosuAgyeman
5th Jan 2025 @ 05:38
Once scheduled maintenance has completed, it should appear in the incident timeline.
jbrooksuk
5th Oct 2024 @ 07:42
Steps to reproduce this issue:
- having a migration file in the package.
- the migration file is already prefixed by a date and time.
- the package is configured with
->runsMigrations()
in it's ServiceProvider. - publish the migrations of the package. then the published migration name would prefixed by date again!
I reproduced this issue not only in my private package, but also in filament-attachmate package, which has a migration named as
database/migrations/2024_02_24_192352_create_attachments_table.php
and the package's service provider is allowed to run migrations:
class FilamentAttachmateServiceProvider extends PackageServiceProvider
{
public function configurePackage(Package $package): void
{
$package
->name('filament-attachmate')
->hasMigrations([
'2024_02_24_192352_create_attachments_table'
])
->runsMigrations();
}
}
everything is ok and the migration is successfully loaded. but after publishing the migration, the published filename would be prefixed again with a new date time string:
Copying file [vendor/zeeshantariq/filament-attachmate/database/migrations/2024_02_24_192352_create_attachments_table.php] to [database/migrations/2024_10_07_135947_2024_02_24_192352_create_attachments_table.php] DONE
the published file is prefixed by 2024_10_07_135947_2024_02_24_192352_
which is the date in vendor's filename prefixed by published date!
Some changes in the generateMigrationName method might fix this issue.
imami
7th Oct 2024 @ 14:42
I think a "Manage Localization" settings page would be more useful for language settings or something else like display timezone...
jbrooksuk
30th Oct 2024 @ 16:37
The dashboard should offer the ability to toggle the theme between:
- Automatic (System)
- Light
- Dark
Further, the dashboard should have a "Theme" option to force a theme mode.
jbrooksuk
3rd Oct 2024 @ 18:34
Provide updates to new functionalities in the v2 of the package.
kwakuOfosuAgyeman
5th Jan 2025 @ 05:45
Hi! If I use this package with my project I has a problem. My package.json has a "git dependency" like this:
{
"peerDependencies": {
"package": "git+ssh://git@bitbucket.org/team/project.git"
}
}
And npm-install-peers
breaks.
JWo1F
18th Dec 2017 @ 08:52
In raising this issue, I confirm the following (please check boxes):
- I have read and understood the contributors guide.
- I have checked the pull requests tab for existing solutions/implementations to my issue/suggestion.
- I have checked that the bug-fix I am reporting can be replicated.
Description of the problem
One of the important reasons for using hyperscript is that it handles escaping of characters which are reserved in html. Which prevents XSS.
spatie/html-element does not do this. Mainly because it uses strings as intermediate format instead of an object representation of the DOM.
Erikvv
1st Feb 2018 @ 02:19
Octane Version
2.6.0
Laravel Version
11.35.0
PHP Version
8.3
What server type are you using?
Swoole
Server Version
6.0.0
Database Driver & Version
No response
Description
Partitioned cookies does not set
Steps To Reproduce
set laravel env to SESSION_PARTITIONED_COOKIE=true
Set-Cookie header without "partitioned"
jamesRUS52
29th Dec 2024 @ 14:44
Incidents can be marked as “Sticky” which I think actually makes more sense to just be labelled as “Pin to top”. Logic needs implementing for this.
- Update language string from "Sticky" to "Pin to Top".
- Any "Sticky" incidents should be at the top of the timeline.
jbrooksuk
3rd Oct 2024 @ 18:30
Calling for help from Docker experts. We need to create the best possible docker-compose.yml
file for this project. The application requirements are well defined (we use env vars, Webpack Encore, PHP 7.1, Symfony 4.1, SQLite database, etc.) so it should be possible to create that file.
javiereguiluz
21st May 2018 @ 09:37